This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Add dshaw and ljharb as NodeSlackers liasons - #410
Merged
Conversation
refack
approved these changes
Nov 2, 2018
Contributor
|
Hello @chasingSublimity and thank you for the contribution 🥇
+1 from me. |
refack
approved these changes
Nov 2, 2018
bnb
approved these changes
Nov 2, 2018
bnb
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Love the clarification 💚
3 tasks
ljharb
approved these changes
Nov 3, 2018
codeekage
approved these changes
Nov 4, 2018
ljharb
reviewed
Nov 4, 2018
Contributor
|
Congratulations @chasingSublimity on getting promoted by GitHub from: Hope to see you contributing again in the future 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381
Is it worth adding some copy stating that collaborator liaisons are the point of contact for their given communities? Granted, the term
liaisonmight make any clarification redundant, but I personally wouldn't think to reach out to the listed Node collaborators if I had trouble getting an invitation to a community.The copy could be as simple as