Skip to content

Conversation

canerakdas
Copy link
Member

Description

Following nodejs/nodejs.org#8133

@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 21:39
@canerakdas canerakdas requested a review from a team as a code owner September 1, 2025 21:39
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Sep 1, 2025 9:41pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enforces the use of curly braces for all control statements by adding the ESLint curly rule and updating existing code to comply with this requirement.

  • Adds ESLint curly rule with "all" option to enforce braces around all control statements
  • Updates if statements in threading and CSS utilities to use curly braces

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eslint.config.mjs Adds curly braces enforcement rule
src/threading/index.mjs Wraps single-line if statement with braces
src/generators/web/utils/css.mjs Wraps single-line if statement with braces

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.69%. Comparing base (79e20a8) to head (47bebb3).
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/generators/web/utils/css.mjs 0.00% 3 Missing ⚠️
src/threading/index.mjs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   74.72%   74.69%   -0.03%     
==========================================
  Files         107      107              
  Lines       10436    10440       +4     
  Branches      681      681              
==========================================
  Hits         7798     7798              
- Misses       2636     2640       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller merged commit 904b9da into nodejs:main Sep 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants