Skip to content

fix(msvs): don't preprocess marmasm sources on vs2022+ #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dennisameling wants to merge 1 commit into from
Closed

fix(msvs): don't preprocess marmasm sources on vs2022+ #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pylib/gyp/generator/msvs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3633,6 +3633,15 @@ def _AddSources2(
elif file_name.startswith("$("):
file_name = re.sub(r"^\$\([^)]+\)\\", "", file_name)
detail.append(["ObjectFileName", "$(IntDir)\\" + file_name])
if element == "MARMASM":
# When compiling on VS2022+, compilation fails with a C1083 as
# MARMASM tries to preprocess by default.
# https://developercommunity.visualstudio.com/t/ARM64---fatal-error-C1083:-Cannot-open/10119540
detail.append([
"PreprocessWithCl",
{"Condition": "'$(VisualStudioVersion)' >= '17.0'"},
"false"
])
grouped_sources[group].append([element, {"Include": source}] + detail)


Expand Down