Conversation
The servers hosting the header packages for Electron return 403 instead of 404 for the constructed URL for arm64 node.lib for older releases that do not support arm64. PR-URL: nodejs#1934 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: João Reis <reis@janeasystems.com>
| 8. `sudo xcode-select --reset` # Enter root password. No output is normal. | ||
| 9. Repeat step 5 above. Is the path different this time? Repeat the _acid test_. | ||
|
|
||
| ### I did all that and the acid test still does not pass :-( |
There was a problem hiding this comment.
Could I please get your review on this PR?
|
Two things I wouldn't mind seeing: a link from the README pointing out its existence (otherwise this will be ignored) and a TTL at the top of the doc, maybe something like this in italics:
An obvious signal for whoever's running this project in a ~year. Otherwise it's pure cruft making a mess in the root directory. |
| 9. Repeat step 5 above. Is the path different this time? Repeat the _acid test_. | ||
|
|
||
| ### I did all that and the acid test still does not pass :-( | ||
| 1. `sudo rm -rf $(xcode-select -print-path)` # Enter root password. No output is normal. |
There was a problem hiding this comment.
This actually worked for me, thnx!
|
Maybe put in directory |
Co-Authored-By: Ted Morin <morinted@gmail.com>
rvagg
left a comment
There was a problem hiding this comment.
lgtm, anyone else have an opinion before we merge?
| ### Two roads | ||
| There are two main ways to install `node-gyp` on macOS: | ||
| 1. With the full Xcode (~7.6 GB download) from the `App Store` app. | ||
| 2. With the _much_ smaller Xcode Command Line Tools via `xcode-select -install` |
There was a problem hiding this comment.
There's a "-" missing in "xcode-select -install"
PR-URL: #1940 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
fixed, squashed and merged in 8ec2e68 |
PR-URL: #1940 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Document the lessons learned from #1779, #1861, #1927 and elsewhere to
enable users to consistently install
node-gypon macOS Catalina (v10.15).@AshCripps Your review please.
Checklist
npm install && npm testpassesDescription of change