windows build broken

[gengjiawen]

https://github.com/nodejs/node-v8/runs/1340956947

D:\a\node-v8\node-v8\out\Release\obj\global_intermediate\torque-generated\objects-body-descriptors-inl.inc(78,22): error C2027: use of undefined type 'v8::internal::InternalClass' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\deps\v8\src\heap\objects-visiting.h(68): message : see declaration of 'v8::internal::InternalClass' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\out\Release\obj\global_intermediate\torque-generated\objects-body-descriptors-inl.inc(78,37): error C2079: 'BodyDescriptor' uses undefined class 'v8::internal::InternalClass' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\out\Release\obj\global_intermediate\torque-generated\objects-body-descriptors-inl.inc(78,37): error C2146: syntax error: missing ';' before identifier 'final' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\out\Release\obj\global_intermediate\torque-generated\objects-body-descriptors-inl.inc(78,43): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\out\Release\obj\global_intermediate\torque-generated\objects-body-descriptors-inl.inc(78,43): error C2059: syntax error: ':' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\out\Release\obj\global_intermediate\torque-generated\objects-body-descriptors-inl.inc(78,45): error C2059: syntax error: 'public' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
D:\a\node-v8\node-v8\out\Release\obj\global_intermediate\torque-generated\objects-body-descriptors-inl.inc(78,81): error C2143: syntax error: missing ';' before '{' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

[targos]

Here's the file as generated on my side:

Details

class FixedArray::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return FixedArray::cast(raw_object).AllocatedSize();
  }

};
class WeakFixedArray::BodyDescriptor final : public SuffixRangeWeakBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return WeakFixedArray::cast(raw_object).AllocatedSize();
  }

};
class SloppyArgumentsElements::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return SloppyArgumentsElements::cast(raw_object).AllocatedSize();
  }

};
class FeedbackVector::BodyDescriptor final : public SuffixRangeWeakBodyDescriptor<24> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return FeedbackVector::cast(raw_object).AllocatedSize();
  }

};
class WeakArrayList::BodyDescriptor final : public SuffixRangeWeakBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return WeakArrayList::cast(raw_object).AllocatedSize();
  }

};
class OnHeapBasicBlockProfilerData::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 56;
  }

};
class ConsString::BodyDescriptor final : public SuffixRangeBodyDescriptor<16> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 32;
  }

};
class SeqOneByteString::BodyDescriptor final : public DataOnlyBodyDescriptor {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return SeqOneByteString::cast(raw_object).AllocatedSize();
  }

};
class SeqTwoByteString::BodyDescriptor final : public DataOnlyBodyDescriptor {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return SeqTwoByteString::cast(raw_object).AllocatedSize();
  }

};
class SlicedString::BodyDescriptor final : public SuffixRangeBodyDescriptor<16> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 32;
  }

};
class ThinString::BodyDescriptor final : public SuffixRangeBodyDescriptor<16> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 24;
  }

};
class InternalClass::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 24;
  }

};
class SmiPair::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 24;
  }

};
class SmiBox::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 24;
  }

};
class ExportedSubClassBase::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 24;
  }

};
class ExportedSubClass::BodyDescriptor final : public BodyDescriptorBase {
 public:
  static bool IsValidSlot(Map map, HeapObject obj, int offset) {
      bool valid_slots[] = {1,1,1,0,1,};
      return valid_slots[static_cast<unsigned int>(offset)/kTaggedSize];
  }

  template <typename ObjectVisitor>
  static inline void IterateBody(Map map, HeapObject obj, int object_size, ObjectVisitor* v) {
    IteratePointers(obj, 8, 24, v);
    IteratePointer(obj, 32, v);
  }

  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 40;
  }

};
class AbstractInternalClassSubclass1::BodyDescriptor final : public DataOnlyBodyDescriptor {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 8;
  }

};
class AbstractInternalClassSubclass2::BodyDescriptor final : public DataOnlyBodyDescriptor {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 8;
  }

};
class InternalClassWithSmiElements::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return InternalClassWithSmiElements::cast(raw_object).AllocatedSize();
  }

};
class InternalClassWithStructElements::BodyDescriptor final : public SuffixRangeBodyDescriptor<16> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return InternalClassWithStructElements::cast(raw_object).AllocatedSize();
  }

};
class ExportedSubClass2::BodyDescriptor final : public BodyDescriptorBase {
 public:
  static bool IsValidSlot(Map map, HeapObject obj, int offset) {
      bool valid_slots[] = {1,1,1,0,1,};
      return valid_slots[static_cast<unsigned int>(offset)/kTaggedSize];
  }

  template <typename ObjectVisitor>
  static inline void IterateBody(Map map, HeapObject obj, int object_size, ObjectVisitor* v) {
    IteratePointers(obj, 8, 24, v);
    IteratePointer(obj, 32, v);
  }

  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 40;
  }

};
class SortState::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
 public:
  static inline int SizeOf(Map map, HeapObject raw_object) {
    return 136;
  }

};

[gengjiawen]

Looks like need extra header include for msvc.

[targos]

What about the syntax errors?

[gengjiawen]

Not sure, but from my experience, fix front error will be helpfully for latter error.

[targos]

If you have an idea about which header should be included in which file(s), I'm happy to try it on my Windows machine.

[gengjiawen]

I have not got time to debug yet. I guess this not on hurry since v8 8.8 official release take some time ?

[gengjiawen]

Looks like something wrong with torque-gernerated

This file not generated on windows.

[vsemozhetbyt]

It seems all other builds are also absent for the last 5 days.

[targos]

V8 now requires ICU 68. Canary should be fixed after nodejs/node#36187 lands.

[gengjiawen]

@tebbi I am not familiar with torque, any special part should I check for windows ? #183 (comment)

[targos]

@gengjiawen I checked with V8 8.8 PR (nodejs/node#36139) and the same files are present in the torque-generated directory on both Windows and Linux.

[targos]

Found it: it's the file torque-generated/src/objects/torque-defined-classes-tq-inl.inc that's wrong. It's completely empty on Windows.

Edit: other files are wrong. For example torque-defined-classes-tq.cc

[targos]

Okay, so the issue is in https://github.com/v8/v8/blob/7111248e40379c540ae4c0325a8fb7fc792b9d43/src/torque/source-positions.cc#L48-L55

The method is called with "src/objects/torque-defined-classes.tq" and it matches nothing because in the for loop, all strings have a backslash separator.

[targos]

I'm trying a fix in GYP 🤞

[targos]

I pushed the fix to nodejs/node@c220ba6
Now I'm hitting an issue with mkcodecache:

.\out\Release\mkcodecache.exe test.cc
node:lib/internal/bootstrap/loaders:4343: Uncaught SyntaxError: Identifier 'internalBinding' has already been declared
Failed to compile lib/internal/bootstrap/loaders

/cc @joyeecheung ?