investigate flaky test-http-client-race-2 on SmartOS

[Trott]

• Version: v8.0.0-pre
• Platform: SmartOS16-64
• Subsystem: http

https://ci.nodejs.org/job/node-test-commit-smartos/6613/nodes=smartos16-64/console

not ok 718 parallel/test-http-client-race-2
  ---
  duration_ms: 60.142
  severity: fail
  stack: |-
    timeout

[Trott]

I wonder if we should open a single issue for this and all the other first-time SmartOS timeout test failures we've been seeing in the last week or three.

#11026
#11019
#11003
#10966
#10592

One thing they all seem to have in common: They are all http/tls tests. Totally guessing here, but maybe the test suite is triggering some sort of firewall/intrusion detection on the host causing it to silently drop a connection or something like that?

@nodejs/testing @nodejs/platform-smartos @nodejs/http

[misterdjules]

@Trott I'll try to take a look at this before the end of the week, if not early next week at the latest. Sorry for the delay :(

[misterdjules]

Looking at it now.

[misterdjules]

So far, I haven't been able to reproduce the problem described by any of the issues listed above.

In order to be able to get more information and investigate future spurious failures, I submitted a PR that sends SIGABRT instead of SIGTERM to test processes that timeout. This will allow us to take a look at core files generated from these processes with tools such as llnode and mdb_v8, and will potentially help us root cause these issues.

In the meantime I'll continue trying to reproduce and investigate those issues, I'll keep you posted.

[Trott]

I haven't noticed any SmartOS failures lately that are similar to these. It's possible these issues have stopped happening on CI. In which case, they may be very difficult to reproduce at this point.
¯\(ツ)/¯