test: new flakiness in test-process-kill-null.js

[refack]

• Version: master
• Platform: Windows
• Subsystem: test,process

44483b6 introduced flakiness to test/parallel/test-process-kill-null.js.
Looking for advice on the best course of action:

1. Revert & reopen PR.
2. Fix.
3. Mark as flaky.

/cc @nodejs/testing @nodejs/platform-windows

[Trott]

When in doubt, I'd say revert & reopen PR.

I imagine if you were confident that you could fix it quickly (or determined to do so), then that's what you'd do and you wouldn't ask. :-D

And I'd reserve "mark as flaky" for situations where we do not know how to fix the test. If reverting fixes the flakiness, I'd say that's preferable. green > yellow

[Trott]

Oh, I guess another factor is just how flaky. Like, if it's one in a thousand runs, leaving it open while there's an active effort to fix it over a few days is A-OK to me. If it's one in 10, OMG no, revert.

[refack]

I guess it's more in the 1 in 10 range so #14142.
Maybe even a real bug...
Now I can sleep on this more peacefully ...