sequential/test-benchmark-http - consistent intermittent failure

[mhdawson]

• Version: master
• Platform: SmartOS and likely others
• Subsystem: http

Latest CI runs show intermittent failure on
sequential/test-benchmark-http
https://ci.nodejs.org/job/node-test-commit-smartos/10138/nodes=smartos16-64/console

not ok 1511 sequential/test-benchmark-http
  ---
  duration_ms: 60.255
  severity: fail
  stack: |-
    timeout
  ...

I believe this is quite likely due to turning off snapshots for the security release as it was one we saw fail on ARM in some of the private runs.

We'll need to investigate and figure out if the test needs more time or something more is going on.

[refack]

ditto https://ci.nodejs.org/job/node-test-commit-smartos/10136/nodes=smartos15-64/

[refack]

I have a feeling test-benchmark-http is also fudging up test-benchmark-net that is the next test in line:

not ok 1511 sequential/test-benchmark-http
  ---
  duration_ms: 60.279
  severity: fail
  stack: |-
    timeout
  ...
not ok 1512 sequential/test-benchmark-net
  ---
  duration_ms: 3.429
  severity: fail
  stack: |-
    
    net/net-c2s-cork.js
    events.js:182
          throw er; // Unhandled 'error' event
          ^
    
    Error: listen EADDRINUSE :::12346
        at Object.exports._errnoException (util.js:1023:11)
        at exports._exceptionWithHostPort (util.js:1046:20)
        at Server.setupListenHandle [as _listen2] (net.js:1319:14)
        at listenInCluster (net.js:1367:12)
        at Server.listen (net.js:1467:7)
        at server (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/benchmark/net/net-c2s-cork.js:75:10)
        at main (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/benchmark/net/net-c2s-cork.js:40:3)
        at Benchmark.process.nextTick (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/benchmark/common.js:34:28)
        at _combinedTickCallback (internal/process/next_tick.js:131:7)
        at process._tickCallback (internal/process/next_tick.js:180:9)
    assert.js:48
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: 1 === 0
        at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/test/sequential/test-benchmark-net.js:21:10)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:201:12)
  ...

https://ci.nodejs.org/job/node-test-commit-smartos/10143/nodes=smartos15-64/console

[Trott]

Looks like #14180 fixes this issue.

[Trott]

I have a feeling test-benchmark-http is also fudging up test-benchmark-net that is the next test in line:

@refack test-benchmark-net is failing independently on Raspberry Pi devices, but I think I have a fix for that.

[mhdawson]

This is failing on the PPC linux machines as well.

ex:

https://ci.nodejs.org/job/node-test-commit-plinux/nodes=ppcbe-ubuntu1404/10158/console

[mhdawson]

@refack agreed, I think the second failure is just because the failure of the first test.