V8 tests failing

[mhdawson]

• Version: master
• Platform: all
• Subsystem: v8

Tests have been failing since Aug 12:

https://ci.nodejs.org/job/node-test-commit-v8-linux/

test/test/inspector/isolate-data.o
  CXX(target) /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/inspector-test/test/inspector/task-runner.o
../test/inspector/inspector-test.cc:667:11: error: no member named 'FreeContext' in 'IsolateData'; did you mean 'FromContext'?
    data->FreeContext(context);
          ^~~~~~~~~~~
          FromContext
.././test/inspector/isolate-data.h:31:23: note: 'FromContext' declared here
  static IsolateData* FromContext(v8::Local<v8::Context> context);
                      ^
  CXX(target) /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/mkgrokdump/test/mkgrokdump/mkgrokdump.o
  CXX(target) /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/parser-shell/tools/parser-shell.o

[mhdawson]

Will try cleaning workspace as possibly its a stale test.

[mhdawson]

CI run to see if workspace clean resolved the issue: https://ci.nodejs.org/job/node-test-commit-v8-linux/

[mhdawson]

CI re-runs failed so does not look like an issue with the environment.

@jkrems failure seems to be related to this

/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/mkgrokdump/test/mkgrokdump/mkgrokdump.o
../test/inspector/inspector-test.cc

which makes me guess it might be related to the inspector ?

@nodejs/v8 FYI as well.

[hybrist]

Guess some dependency was missed when cherry-picking this? 73c59bb

/cc @eugeneo

[hybrist]

Yeah, looks like the original commit contained the header change to add FreeContext to IsolateData (v8/v8@f19b889#diff-119937d090f8cb387f0b4d902c9e981fR71) but the cherry-pick does not contain it.

[eugeneo]

Looking into it.