http2 - clarify difference between 'streamClosed' and 'close'

[ronag]

This is not really well documented. Even comments in the code just say "distinctly different". I'm mostly interested in how it affects pump which seems to be using close instead of streamClosed for http2 requests.

[ronag]

ping?

[gibfahn]

cc/ @nodejs/http2

[mcollina]

I think this is a bug.

@jasnell why are we using 'streamClosed' instead of 'close' in https://github.com/nodejs/node/blob/master/lib/internal/http2/core.js#L1527?

[jasnell]

I added 'streamClosed' because at the time it was not clear if we should tie the protocol idea of a closed stream to the existing 'close' event used for the Streams API. One difference in particular is that 'streamClosed' will provide the protocol error number as reported by the RST_STREAM frame. These likely could be unified in some way but I have not taken the time to look into it further.