configure: clang version is misdetected for double-digit clang versions

[mistydemeo]

• Version: v10.3.0
• Platform:
• Subsystem:

Configure performs a check to see if clang is newer than 3.4.2. However, this check is done against the string parsed out of the clang output in try_check_compiler: https://github.com/nodejs/node/blob/master/configure#L710 This results in miscomparisons for double-digit clang versions. For example, if clang_version is '10.0.0', then clang_version < '3.4.2' is false even though clang 10 is definitely newer than 3.

[Trott]

Thanks! #21173 should fix this.

[mistydemeo]

Thanks! Works for me, though it left a spurious "compiler is too old" warning; I fixed that in #21183.

[addaleax]

I think this can be closed? Let us know if I’m mistaken. :)