sequential/test-tls-session-timeout failing

[Trott]

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5519/console

test-rackspace-ubuntu1604-x64-1

00:06:39 not ok 101 pummel/test-tls-session-timeout
00:06:39   ---
00:06:39   duration_ms: 0.214
00:06:39   severity: fail
00:06:39   exitcode: 1
00:06:39   stack: |-
00:06:39     assert.js:85
00:06:39       throw new AssertionError(obj);
00:06:39       ^
00:06:39     
00:06:39     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
00:06:39     + actual - expected
00:06:39     
00:06:39     + 'New'
00:06:39     - 'Reused'
00:06:39         at /home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/pummel/test-tls-session-timeout.js:121:16
00:06:39         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/pummel/test-tls-session-timeout.js:105:7)
00:06:39         at ChildProcess.emit (events.js:198:13)
00:06:39         at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
00:06:39   ...

[Trott]

Two days in a row...

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5572/

test-rackspace-ubuntu1604-x64-1

00:07:01 not ok 101 pummel/test-tls-session-timeout
00:07:01   ---
00:07:01   duration_ms: 0.266
00:07:01   severity: fail
00:07:01   exitcode: 1
00:07:01   stack: |-
00:07:01     assert.js:87
00:07:01       throw new AssertionError(obj);
00:07:01       ^
00:07:01     
00:07:01     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
00:07:01     + actual - expected
00:07:01     
00:07:01     + 'New'
00:07:01     - 'Reused'
00:07:01         at /home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/pummel/test-tls-session-timeout.js:121:16
00:07:01         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/pummel/test-tls-session-timeout.js:105:7)
00:07:01         at ChildProcess.emit (events.js:193:13)
00:07:01         at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
00:07:01   ...

[Trott]

Running locally confirms this is not flaky but actually full-on broken. :-( Had to be something that landed very recently, so I'll bisect. Chances are the test just needs to be updated. Might turn out that it could/should be moved to sequential or parallel as well. More soon....

[Trott]

The first commit that causes this test to fail is 42dbaed. @sam-github Can you look at the test and the results and confirm whether the test needs to be adjusted or if the test failure is indicative of an actual bug introduced in that commit?

[Trott]

Here's the comment explaining what the test does:

// This test consists of three TLS requests --
// * The first one should result in a new connection because we don't have
//   a valid session ticket.
// * The second one should result in connection resumption because we used
//   the session ticket we saved from the first connection.
// * The third one should result in a new connection because the ticket
//   that we used has expired by now.

The failure seems to be with the second connection. It is detecting that it is a new connection when it is expecting it to be a reused connection.

[Trott]

I "fixed" it by setting maxVersion to 'TLSv1.2'. Hopefully that's the correct approach. PR coming momentarily.

[Trott]

PR to address this: #26865