createRequireFromPath does not support directories with a trailing slash

[MylesBorins]

Follow up from e5c8be2

TL;DR

createRequireFromPath('/path/to/dir') has unexpected behavior as it is treated as a file not a directory... createRequireFromPath('/path/to/dir/') works as expected.

Seems like the only way forward would be to introduce a synchronous file / directory stat... which imho is undesirable but I totally see why this creates unexpected behavior.

/cc @BridgeAR @addaleax @devsnek

[mscdex]

Does it really matter since that method is about to be doc-deprecated anyway (#27405)?

[MylesBorins]

@mscdex since createRequire uses it under the hood the behavior is inherited.

[addaleax]

This actually seems like the expected behaviour to me?

[Fishrock123]

Shouldn't createRequireFromPath() raise an error if the path is not (or does not quack like) a directory?

[MylesBorins]

@Fishrock123 since it is a wrapper around new Module it actually expects a file to be passed, not a directory.

import.meta.url for example is a file path, not directory. So if there was an error for non paths then import.meta.url would error

[MylesBorins]

afaik this was properly fixed by ef51cc8