Impossible to catch error during tls.connect(duplex)

[Qualtagh]

• Version: 10.16.3
• Platform: Ubuntu 16.04.1
• Subsystem: tls

There seems to be no way to catch synchronous error of underlying duplex stream during tls.connect operation.
Code sample:

const stream = require('stream');
const tls = require('tls');

const async = false;
process.on('uncaughtException', e=>console.log('uncaught: '+e));

const socket = new stream.Duplex({
    read(size){},
    write(data, encoding, cb){
        let error = new Error('intended error');
        if (async)
            setTimeout(()=>cb(error), 1000);
        else
            cb(error);
    },
});
socket.on('error', e=>console.log('socket error: '+e));

const tls_socket = tls.connect({socket});
tls_socket.on('error', e=>console.log('tls_socket error: '+e));

Expected output:

socket error: Error: intended error
tls_socket error: Error: intended error

Actual output:

socket error: Error: intended error
uncaught: Error: intended error

Changing async to true solves the issue.
Can we allow passing onError handler to tls.connect method? So, it will be set before calling _start() method of TLSSocket.

[cjihrig]

FWIW, Node 13 yields the expected output.

[Qualtagh]

Thank you! Yes, it's fixed now. Seems like error is emitted in nextTick in 13.
For 10, we worked around via copying contents of tls.connect and passing error listener in the beginning.
So, since it has workaround for old releases and fixed in latest release, perhaps it's ok to close the issue.

[github-actions]

This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

[github-actions]

This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.