Getting the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" while module installation by npm

[SergeKornilov]

I get the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" trying to install any module by npm via proxy, for example, request or cheerio:

npm config set proxy http://username:password@proxy.company.com:8080
npm config set https-proxy https://username:password@proxy.company.com:8080

npm install cheerio

//

Thus, request module is not installed at all, and cheerio module is installed without dependencies.

//

npm --version
2.14.3

node --version
v4.1.0

OS: windows xp sp3

[ChALkeR]

cc @indutny

[rvagg]

/cc @nodejs/crypto, @nodejs/platform-windows (windows xp sp3 sets off red flags for me)

[thefourtheye]

Npm folks might also be interested. cc @othiym23 @zkat @iarna

[indutny]

Will look at it today...

[indutny]

I think it may be related to the Windows XP indeed. Checking the libuv code with this regards.

[indutny]

Hm... looks like I was wrong about it, the order of callbacks should be correct even on XP. Continuing the search.

[indutny]

I think it may be a windows-specific thing. May I ask you to give a try to the following patch:

diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
index 1bff757..fc9696f 100644
--- a/lib/_tls_wrap.js
+++ b/lib/_tls_wrap.js
@@ -296,7 +296,11 @@ proxiedMethods.forEach(function(name) {

 tls_wrap.TLSWrap.prototype.close = function closeProxy(cb) {
   if (this._parentWrap && this._parentWrap._handle === this._parent) {
-    setImmediate(cb);
+    if (this._parentWrap._handle)
+      this._parentWrap.once('close', cb);
+    else
+      setImmediate(cb);
+
     return this._parentWrap.destroy();
   }
   return this._parent.close(cb);

Hopefully, it will fix the problem

---

@saghul a question about Windows and uv_close(). There is lots of endgames and everything for cancelling the request. Could it be the case that the uv_close_cb is not invoked on next libuv tick on Windows?

[indutny]

Relevant PR: #2991

[saghul]

a question about Windows and uv_close(). There is lots of endgames and everything for cancelling the request. Could it be the case that the uv_close_cb is not invoked on next libuv tick on Windows?

Yes, AFAIK cancellation could take a bit, so the uv_close callback is not guaranteed to run exactly on the next tick.

[indutny]

@SergeKornilov may I ask you to test this patch? I have really good expectations from it. Let me know if you need some help with building this thing.

[SergeKornilov]

@indutny It something goes wrong when I try to build node.js. I follow installation guide:

1. Start "Visual Studio Command prompt (2010)"
2. Execute "set path=c:\python27;c:\python27\lib;%path%"
3. Execute "python --version" to check and get the result "Python 2.7.10"
4. Then execute "vcbuild.bat release x86" and get nothing.

What's wrong here? obsolet version of VS?