Skip to content

benchmark: dead code #36199

Description

@mscdex
  • Version: master
  • Platform: n/a
  • Subsystem: benchmark

In benchmark/fs/bench-statSync.js, the

  if (statSyncType === 'fstat')
    fs.closeSync(arg);

should instead be

  if (statSyncType === 'fstatSync')
    fs.closeSync(arg);

Although, I'm not sure we even need that bit of code since the OS will automatically clean up any open resources on process exit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.fsIssues and PRs related to file-system APIs and the fs module.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions