Skip to content

[coverage]: nullish coalescing was consuming too many characters #36619

Description

@bcoe
  • Version: *
  • Platform: *
  • Subsystem: test

What steps will reproduce the bug?

see:

Screen Shot 2020-12-18 at 2 47 17 PM

How often does it reproduce? Is there a required condition?

Collect coverage for ??.

What is the expected behavior?

Coverage tracking should terminate at the end of the token after ??.

What do you see instead?

?? keeps consuming until the next block token.

Additional information

This is fixed upstream in v8:

https://chromium-review.googlesource.com/c/v8/v8/+/2576006

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions