Skip to content

Unify node.gyp code styling #41072

Description

@asamuzaK

Version

16.13.1, maybe also 17.2.0 (not tested myself)

Platform

Microsoft Windows NT 10.0.19043.0 x64

Subsystem

node.gyp

What steps will reproduce the bug?

In #40481, it combines multiple lines of strings with \ before a line break.
See node/node.gyp at master · nodejs/node

This \ causes an error in gyp-parser addaleax/gyp-parser: GYP file format parser in JS.

I looked at the .gyp docs GYP - Input Format Reference, I wasn't sure if it allowed to combine multiple lines of strings with \.

But any way, it doesn't match code styling in the same file.
In other places, multiple lines are combined like

['"foo" and '
 '"bar"', {
}]

#L79
#L849

I think #L1479 should follow the same code styling.

How often does it reproduce? Is there a required condition?

Always since 16.13.1

What is the expected behavior?

Do not cause errors in other modules.

What do you see instead?

Parse error in gyp-parser.

Additional information

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.gypIssues and PRs related to GYP and .gyp or .gypi build files.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions