Skip to content

17.7 Regression on url.resolve breaks Yarn 1.x #42279

Description

@arcanis

Version

17.7

Platform

n/a

Subsystem

n/a

What steps will reproduce the bug?

yarn init
yarn add @zkochan/cmd-shim

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Should work as in 17.6

What do you see instead?

info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...

Additional information

Caused by #42136. This diff seems to break Yarn Classic, which does:

url.resolve('https://registry.npmjs.org', '@foo/bar')

Node 17.6: https://registry.npmjs.org/@foo/bar
Node 17.7: https://foo/bar

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    urlIssues and PRs related to the legacy built-in url module.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions