FormData, Response, Request, and Headers have incorrect property descriptors

[KhafraDev]

Version

v18.11.0

Platform

Microsoft Windows NT 10.0.19043.0 x64

Subsystem

No response

What steps will reproduce the bug?

The property descriptors should match such that this test succeeds:

for (const global of [
  'Headers',
  'Request',
  'Response',
  'FormData'
]) {
  const desc = Object.getOwnPropertyDescriptor(globalThis, global)
  
  assert.notStrictEqual(desc, undefined)
  assert.deepStrictEqual(desc.value, globalThis[global])
  assert.ok(desc.writable)
  assert.ok(!desc.enumerable)
  assert.ok(desc.configurable)
}

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

the tests from above pass

What do you see instead?

the descriptors are inconsistent with other environments

Additional information

No response

[bnoordhuis]

If you submit that to WPT, then node will fix that next time we update.

If WPT already contains tests but we're not testing that particular submodule, then please see test/wpt/README.md for how to enable them.

[KhafraDev]

The tests exist https://github.com/web-platform-tests/wpt/blob/master/fetch/api/idlharness.any.js

I will look into enabling these tests in node but I've never worked with node's WPT runner and idlharness tests are a little more involved than other tests. 👍

[targos]

I think we already run idlharness tests for other features (for example URL) without issues.

[KhafraDev]

Cool, I'll look into it once a new version of undici is released and is updated in node. Otherwise a few tests will fail that don't anymore.

[aduh95]

We should probably make sure that Undici is snapshotted, so we can get rid of the lazy-loading without perf implications.

[techsavvyash]

Hey Team.
I am a newbie dev starting out in OSS, I would like to take this issue up, can anyone help me navigate through and fix this.
Thanks

[KhafraDev]

I don't think this issue is actionable. Other globals (Blob and File, if File is ever made a global...) were made getters as well in #45659.

Caveat: we have to make some of the globals lazily-loaded too

[LeonxLJX]

I'd like to take this one (FormData, Response, Request, and Headers have incorrect prop). I'll look into the root cause and follow up with a PR. (claiming via @LeonxLJX)