Skip to content

PipeWrap::Connect() should handle errors from uv_pipe_connect2() #50652

Description

@bnoordhuis

553169f switched from uv_pipe_connect() to uv_pipe_connect2(). The former doesn't return errors (it can't because void) but the latter can and does.

The comment here is no longer applicable:

args.GetReturnValue().Set(0); // uv_pipe_connect() doesn't return errors.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions