Skip to content

Remove calls to APIs deprecated in V8 12.6 #52991

Description

@ajklein

Both updates are trivial:

  • v8::ScriptOrigin's constructor no longer takes an Isolate (it was already unused)
  • v8::SafeForTerminationScope and the Isolate creation param only_terminate_in_safe_scope are gone (they were already no-ops)

See v8#185 for the fixes I made to keep V8's CI happy.

cc @joyeecheung

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    deprecationsIssues and PRs related to deprecations.v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions