Skip to content

build: vcbuild format-md doesn't hit all the things #55216

Description

@srl295

Summary

vcbuild.bat format-md did not reformat .\doc\contributing\maintaining\maintaining-icu.md

Repro

My PR said to run format-md, so:

PS C:\Users\srl29\src\node> .\vcbuild.bat format-md
Running Markdown formatter on docs...
PS C:\Users\srl29\src\node> git status
On branch fix-icu-windows-configure-55214
Your branch is up to date with 'srl295/fix-icu-windows-configure-55214'.

nothing to commit, working tree clean

Investigating, found that format-md only hits doc\*.md.

Workaround

PS C:\Users\srl29\src\node> out\release\node.exe .\tools\lint-md\lint-md.mjs --format .\doc\contributing\maintaining\maintaining-icu.md             

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions