flaky: test-fs-cp

[mhdawson]

Test

test-fs-cp

Platform

Windows x64

Console output

not ok 304 parallel/test-fs-cp
12:01:46   ---
12:01:46   duration_ms: 520.01000
12:01:46   severity: fail
12:01:46   exitcode: 1
12:01:46   stack: |-
12:01:46     node:assert:128
12:01:46       throw new AssertionError(obj);
12:01:46       ^
12:01:46     
12:01:46     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
12:01:46     + actual - expected
12:01:46     
12:01:46     + 'ERR_FS_EISDIR'
12:01:46     - 'ERR_FS_CP_EINVAL'
12:01:46               ^
12:01:46     
12:01:46         at file:///c:/workspace/node-test-binary-windows-js-suites/node/test/parallel/test-fs-cp.mjs:687:12
12:01:46         at c:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:491:15
12:01:46         at node:fs:190:23
12:01:46         at callbackifyOnRejected (node:util:230:10)
12:01:46         at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
12:01:46       generatedMessage: true,
12:01:46       code: 'ERR_ASSERTION',
12:01:46       actual: 'ERR_FS_EISDIR',
12:01:46       expected: 'ERR_FS_CP_EINVAL',
12:01:46       operator: 'strictEqual'
12:01:46     }
12:01:46     
12:01:46     Node.js v24.0.0-pre
12:01:46   ...

Build links

• https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32255/RUN_SUBSET=0,nodes=win11-COMPILED_BY-vs2022/testReport/junit/(root)/parallel/test_fs_cp/

Additional information

No response

[mhdawson]

This might not be a flaky test since it failed even after a resume.
https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32313/

[StefanStojanovic]

This test seems to have failure bursts (https://github.com/nodejs/reliability/issues?q=is%3Aissue%20state%3Aopen%20test-fs-cp). In each, there were a few PRs with all the failures.

However this time it is different, there are many different PRs affected by that and it only happens on Windows 11. We checked this and are fairly certain that this is caused by the latest Windows 11 updates (most likely will fail the same way on Windows 2025). Based on all of that I'll open a PR marking this test as flaky on Windows and will investigate it once it is no longer causing CI failures.

[huseyinacacak-janea]

I opened 2 PRs (libuv/libuv#4696 and libuv/libuv#4698) in libuv and they landed. When a new version of libuv is released and merged into Node, this should be fixed.

[joyeecheung]

Both libuv PRs have been present in the main branch but the test still seems very flaky: they are currently failing in almost all Windows CIs https://ci.nodejs.org/job/node-test-binary-windows-js-suites/

[joyeecheung]

This seems to almost always fail now. I think we should consider splitting it and skipping the always failing test case, otherwise it will make the CI indefinitely orange.