statSync with throwIfNoEntry: false still throws ENOTDIR

[jdalton]

Version

at least Node 20+

Platform

osx

Subsystem

No response

What steps will reproduce the bug?

in your terminal of choice

touch a

then enter into node repl

fs.statSync('./a/b', { throwIfNoEntry: false }) // throws ENOTDIR error

How often does it reproduce? Is there a required condition?

a file exists in part of the path.

What is the expected behavior? Why is that the expected behavior?

I would expect undefined to be returned instead of erroring.

What do you see instead?

it throws a ENOTDIR error.

Additional information

No response

[Ceres6]

Hi! I think this is related with this issue. The problem is that we want to be consistent with the "force" behaviour of the platform, which is that we will suppress ENOENT but no ENOTDIR, maybe the docs need some update.

I'm happy to update them if we agree on that

[juanarbol]

The problem seems that Node.js is only validating for ENOENT and not considering ENOTDIR

node/src/node_file.cc

Line 1088 in 532fff6

return result < 0 && result != UV_ENOENT;

I'll write a work-around for this one.

[Ceres6]

AFAIK we want to keep that behaviour, to be consistent with rm -f. Besides the flag is throwIfNoEntry which matches ENOENT but not necessarily ENOTDIR

[juanarbol]

AFAIK we want to keep that behaviour, to be consistent with rm -f. Besides the flag is throwIfNoEntry which matches ENOENT but not necessarily ENOTDIR

Oh, nice, I had no idea. Thanks for the heads-up. For whatever reason, in my PR the CI seems quite happy (except for ARM); not sure if that behavior is not covered in our tests. This issue seems to be legitimate, I could simply add another helper for Stat to handle files and folders. Not the nicest fix, but a fix.

[Ceres6]

Yeah, you can see the discussion in the issue linked above. It is true that ls doesn't have a -f option as rm does, but I think keeping those two behaviours in sync is probably expected.

It might be a good idea to add some tests on that behaviour to prevent this issue from coming up again. One caveat might be, if I remember correctly, that the behaviour will be platform dependent (e.g. windows won't throw)

[juanarbol]

One caveat might be, if I remember correctly, that the behaviour will be platform dependent (e.g. windows won't throw)

I’m into the “if it’s cross-platform, then it belongs to libuv”. Not sure if we can cover all platforms inside our tests, I think it is cheaper and faster to simply write another helper for dirs and files for Stat.