punycode: remove the module system detection from punycode.js

[yorkie]

• Version: latest
• Platform: any
• Subsystem: punycode

lib/punycode.js looks more like the dependency required by the core module url, which is a third party library, and the current source file lib/punycode.js is not that same style with other source files.

So I propose the following:

• add a deps directory in ./lib directory, so we can put the punycode.js there and load it just like what we are doing except for the source path. (Recommend)
• update the punycode source file to be the CMD way just like other .js files, this also needs us to add tests and maintainer for this little module even though we are just moving them from the punycode.js project.

[yorkie]

Sorry, make a noise issue because of bad networking, closed.

[Fishrock123]

I closed the other. :)

[yorkie]

Ah Thank you @Fishrock123

[yorkie]

cc @mathiasbynens, the author of the current punycode.js :-)

[silverwind]

Why not move it to deps? That way, we could also remove the exception in .eslintignore. I'm not oposed to rewriting (and reducing) the code in there itself, but we have to keep in mind that updating it will be a lot less straight-forward.

[yorkie]

Not putting it into deps just because it's a pure library in pure JavaScript, so it should be loaded in runtime, not the compiling time. This is that the differences.

[jasnell]

Recommend closing this given the decision to deprecate the punycode module bundled in core. See: #7941

[yorkie]

Closing this as @jasnell's recommendation :-)