OUTPUT_FORMAT=csv option is missing from benchmark/common.js

[adrian-nitu-92]

• Version: v7.0.0-pre
• Platform: Linux nova-node 4.2.0-27-generic # 32~14.04.1-Ubuntu SMP Fri Jan 22 15:32:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: benchmark

Patch f99471b
removes OUTPUT_FORMAT=csv option from benchmark/common.js. The patch seems to remove all OUTPUT_FORMAT options, with no alternative.
We found this option especially useful for automatically parsing benchmark results. Is there any chance for it to be re-introduced?

[ChALkeR]

/cc @nodejs/benchmarking

[addaleax]

fwiw, running benchmark/scatter.js produces CSV output.

/cc @AndreasMadsen

[AndreasMadsen]

First of all, the script you should run is now benchmark/run.js, common.js is only used as require('common.js') in the benchmarks.

I don't think we should reintroduce this environment variable, it fells like an ad-hoc solution. But we could easily add a --csv flag to benchmark/run.js, that would do the same.

Would you like to do this yourself, or should I do it?

[mscdex]

IMHO having a --format csv/--format=csv-style flag would be better

[AndreasMadsen]

Agreed. It would be --format csv, that is how the other parameters works.

[adrian-nitu-92]

I looked into the code and will soon send out a pull request that I will link here.

[adrian-nitu-92]

Took a while, but I have a pull request available at: #7961

[AndreasMadsen]

#7961 has now landed in 9e7fd8e 4b527a4 474e629.