test fix: Use assert.strictEqual instead of assert.equal and assert.ok - #10420
Closed
navulirs wants to merge 1 commit into
Closed
test fix: Use assert.strictEqual instead of assert.equal and assert.ok#10420navulirs wants to merge 1 commit into
navulirs wants to merge 1 commit into
Conversation
addaleax
approved these changes
Dec 23, 2016
Contributor
|
Commit message should be formatted according to the contributing guide. The correct subsystem in this case is |
Contributor
Author
|
Hi I did amend the commit and force push with "test: Use assert.strictEqual instead of assert.equal and assert.ok" - this PR's title still shows as test fix: instead of just test: . i'm not sure how to get this corrected. |
cjihrig
approved these changes
Dec 23, 2016
jasnell
approved these changes
Dec 23, 2016
This was referenced Dec 24, 2016
Member
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 24, 2016
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: nodejs#10420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 0304848. |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: #10420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: #10420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: #10420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: #10420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: #10420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: #10420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
Use assert.strictEqual instead of assert.equal and assert.ok PR-URL: #10420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Description of change