replacc string concatenation in test/parallel/test-https-unix-socket-… - #14282
Closed
zyziyun wants to merge 1 commit into
Closed
replacc string concatenation in test/parallel/test-https-unix-socket-…#14282zyziyun wants to merge 1 commit into
zyziyun wants to merge 1 commit into
Conversation
…self-signed.js with template literals
Member
gibfahn
approved these changes
Jul 16, 2017
cjihrig
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
Trott
reviewed
Jul 16, 2017
| const options = { | ||
| cert: fs.readFileSync(common.fixturesDir + '/test_cert.pem'), | ||
| key: fs.readFileSync(common.fixturesDir + '/test_key.pem') | ||
| cert: fs.readFileSync(`${common.fixturesDir}/test_cert.pem`), |
Member
There was a problem hiding this comment.
@zyziyun Would you consider altering these to use path.join() instead? For example:
cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'),
Member
|
This change already landed in #14286. Closing. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…self-signed.js with template literals
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)