[jsconfcn] test: replace string concatenation - #14295
Conversation
replace string-concation in test/async-hooks/test-signalwrap.js with template literals
|
(It seems to be duplicate of #14269) |
|
|
||
| let count = 0; | ||
| exec('kill -USR2 ' + process.pid); | ||
| exec(`kill -USR2 ${process.pid}`); |
There was a problem hiding this comment.
Should use process.kill(pid, signal) - https://nodejs.org/api/process.html#process_process_kill_pid_signal
There was a problem hiding this comment.
Thank you @refack.
It's better to use the process.kill(pid, signal), will update once I'm avaliable.
|
@4garfield thank you very much for you contribution. "Change requests" are a normal part of the process. Personally I'd be very happy if you did follow up and made the code even better 👍 |
|
CI was green but I canceled it before the Raspberry Pi 1 devices finished in order to help with our current CI backlog problem. Not going to land right now to give @4garfield a chance to implement @refack's suggestion. |
Replace string concatenation in test/async-hooks/test-signalwrap.js with template literals. PR-URL: #14295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in 651fc55, thank you for your contribution! 🎉 CI on master: https://ci.nodejs.org/job/node-test-commit-linuxone/7502/ If you want to follow @refack's suggestion, feel free to open a separate PR. |
Replace string concatenation in test/async-hooks/test-signalwrap.js with template literals. PR-URL: #14295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
replace string-concation in test/async-hooks/test-signalwrap.js with template literals
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)