Skip to content

test: added dgram benchmark test - #16113

Closed
jopann wants to merge 1 commit into
nodejs:masterfrom
jopann:master
Closed

test: added dgram benchmark test#16113
jopann wants to merge 1 commit into
nodejs:masterfrom
jopann:master

Conversation

@jopann

@jopann jopann commented Oct 9, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 9, 2017
@jopann

jopann commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

This was a second contribution suggestion from Node.js interactive conf

@mscdex mscdex added dgram Issues and PRs related to UDP and the dgram module. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. labels Oct 10, 2017
@joyeecheung

Copy link
Copy Markdown
Member

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More settings should be passed to reduce the number of benchmarks each file runs to one. So type=send, num=1, len=1, and probably others...

@apapirovski

Copy link
Copy Markdown
Contributor

Hi @jopann, would you like to follow up on this and make the changes requested by @Trott? Thanks!

@apapirovski

Copy link
Copy Markdown
Contributor

Closing this as there hasn't been any movement on it in a while but feel free to re-open if you would like to continue work on this, @jopann.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. dgram Issues and PRs related to UDP and the dgram module. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants