Skip to content

test: change callback function to arrow function - #17734

Closed
rt33 wants to merge 1 commit into
nodejs:masterfrom
rt33:refactor/test-domain-no-error-handler-abort-on-uncaught-9
Closed

test: change callback function to arrow function#17734
rt33 wants to merge 1 commit into
nodejs:masterfrom
rt33:refactor/test-domain-no-error-handler-abort-on-uncaught-9

Conversation

@rt33

@rt33 rt33 commented Dec 18, 2017

Copy link
Copy Markdown
Contributor

Refactored some callback functions to arrow functions
This is practice on code-and-learn for contributing oss.
nodejs/code-and-learn#78

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Dec 18, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 18, 2017
@gireeshpunathil

gireeshpunathil commented Dec 18, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/12168/

@maclover7 maclover7 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 18, 2017
@gireeshpunathil

gireeshpunathil commented Dec 19, 2017

Copy link
Copy Markdown
Member

arm failures unrelated, landing.

gireeshpunathil pushed a commit that referenced this pull request Dec 19, 2017
@rt33 @gireeshpunathil
test: change callback function to arrow function
ed15c71 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil

gireeshpunathil commented Dec 19, 2017

Copy link
Copy Markdown
Member

Landed as ed15c71 , thanks for the contribution!

@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@rt33 @MylesBorins
test: change callback function to arrow function
5b64739 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@rt33 @MylesBorins
test: change callback function to arrow function
5a9694e 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@rt33 @MylesBorins
test: change callback function to arrow function
b99ebde 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@rt33 @MylesBorins
test: change callback function to arrow function
567abae 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@rt33 @gibfahn
test: change callback function to arrow function
e495981 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@rt33 @MylesBorins
test: change callback function to arrow function
7725506 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@rt33 @MylesBorins
test: change callback function to arrow function
449b0c3 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@rt33 @MylesBorins
test: change callback function to arrow function
cb78543 
PR-URL: #17734
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
@maclover7 maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@rt33 @gireeshpunathil @jasnell @cjihrig @maclover7 @tniessen @MylesBorins @addaleax @nodejs-github-bot