Skip to content

test: improve to use template string - #17895

Closed
sreepurnajasti wants to merge 1 commit into
nodejs:masterfrom
sreepurnajasti:template
Closed

test: improve to use template string#17895
sreepurnajasti wants to merge 1 commit into
nodejs:masterfrom
sreepurnajasti:template

Conversation

@sreepurnajasti

@sreepurnajasti sreepurnajasti commented Dec 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Dec 28, 2017
@gibfahn

gibfahn commented Dec 28, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/15109/

BridgeAR
BridgeAR reviewed Dec 28, 2017
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is just me but I feel like the old version is actually even nicer to read.

@gibfahn

gibfahn commented Dec 28, 2017

Copy link
Copy Markdown
Member

Maybe it is just me but I feel like the old version is actually even nicer to read.

Interesting, I find the fact that the second arg goes into the formatting string of the first arg, but the third arg is a separate thing passed to console.log unintuitive, so I prefer this.

@BridgeAR BridgeAR added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Dec 28, 2017
@BridgeAR

BridgeAR commented Dec 28, 2017

Copy link
Copy Markdown
Member

Landed in 968e20c

@BridgeAR BridgeAR closed this Dec 28, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 28, 2017
@sreepurnajasti @BridgeAR
test: improve to use template string
968e20c 
PR-URL: nodejs#17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@sreepurnajasti
sreepurnajasti deleted the template branch December 29, 2017 04:30
@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@sreepurnajasti @MylesBorins
test: improve to use template string
134238c 
PR-URL: #17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@sreepurnajasti @MylesBorins
test: improve to use template string
97b1a3c 
PR-URL: #17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@sreepurnajasti @MylesBorins
test: improve to use template string
421eb75 
PR-URL: #17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@sreepurnajasti @gibfahn
test: improve to use template string
b451339 
PR-URL: #17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@sreepurnajasti @gibfahn
test: improve to use template string
38f56cb 
PR-URL: #17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@sreepurnajasti @MylesBorins
test: improve to use template string
c668b55 
PR-URL: #17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@sreepurnajasti @MylesBorins
test: improve to use template string
d356ba2 
PR-URL: #17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@sreepurnajasti @MylesBorins
test: improve to use template string
2c554a9 
PR-URL: #17895
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+1 more reviewer
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sreepurnajasti @gibfahn @BridgeAR @jasnell @lpinca @cjihrig @addaleax @nodejs-github-bot