Skip to content

src: fix indentation of params in env-inl.h - #19390

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:env-inl-line-up-params
Closed

src: fix indentation of params in env-inl.h#19390
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:env-inl-line-up-params

Conversation

@danbev

@danbev danbev commented Mar 16, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 16, 2018
@danbev

danbev commented Mar 16, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13703/

@addaleax addaleax added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Mar 16, 2018
@danbev

danbev commented Mar 18, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 6050add.

@danbev danbev closed this Mar 18, 2018
@danbev
danbev deleted the env-inl-line-up-params branch March 18, 2018 11:26
danbev added a commit that referenced this pull request Mar 18, 2018
@danbev
src: fix indentation of params in env-inl.h
6050add 
PR-URL: #19390
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@danbev @MylesBorins
src: fix indentation of params in env-inl.h
3043330 
PR-URL: #19390
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@danbev @MylesBorins
src: fix indentation of params in env-inl.h
43c482b 
PR-URL: #19390
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Mar 20, 2018
Merged
@tniessen tniessen removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs proposed for a shorter-than-standard waiting period before landing. lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@danbev @jasnell @addaleax @targos @tniessen @nodejs-github-bot