test: update test to comply with lint rule - #19784
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/413/ (Lite CI because it only touches a comment and no executable code.) |
4 tasks
Member
Author
|
@nodejs/collaborators Some fast-track approvals for this to unbreak CI would be great! |
Member
Author
|
(CI is green.) |
not-an-aardvark
approved these changes
Apr 4, 2018
mmarchini
approved these changes
Apr 4, 2018
Member
Author
|
Landed in 8891072 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 4, 2018
Ref: nodejs#19502 (comment) PR-URL: nodejs#19784 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
targos
pushed a commit
that referenced
this pull request
Apr 4, 2018
Ref: #19502 (comment) PR-URL: #19784 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #19502 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes