Skip to content

tools: fix typo in .eslintrc.js - #21449

Closed
boneskull wants to merge 1 commit into
nodejs:masterfrom
boneskull:eslintrc-typo-fix
Closed

tools: fix typo in .eslintrc.js#21449
boneskull wants to merge 1 commit into
nodejs:masterfrom
boneskull:eslintrc-typo-fix

Conversation

@boneskull

Copy link
Copy Markdown
Member

Refs: #18566

astrictEqual is not a thing.

Checklist

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 21, 2018
@vsemozhetbyt

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/887/
(Please, run full CI if needed.)

@tniessen tniessen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 21, 2018
@tniessen

Copy link
Copy Markdown
Member

Fast-tracking has been approved.

@Trott

Trott commented Jun 21, 2018

Copy link
Copy Markdown
Member

Landed in 2f1a23e

Thanks!

@Trott Trott closed this Jun 21, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 21, 2018
Refs: nodejs#18566

PR-URL: nodejs#21449
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jun 22, 2018
Refs: #18566

PR-URL: #21449
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@boneskull
boneskull deleted the eslintrc-typo-fix branch June 22, 2018 18:22
@targos targos mentioned this pull request Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants