Skip to content

doc: update LICENSE file - #21472

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:license
Closed

doc: update LICENSE file#21472
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:license

Conversation

@Trott

@Trott Trott commented Jun 22, 2018

Copy link
Copy Markdown
Member

Running license-builder.sh seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.

@richardlau

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: update LICENSE file
4c01563 
Running `license-builder.sh` seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.
@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/125/pipeline

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 22, 2018
@Trott

Trott commented Jun 22, 2018

Copy link
Copy Markdown
Member Author

Anybody know what's up with the http_parser license text that is removed?

@Trott Trott mentioned this pull request Jun 22, 2018
Closed
2 tasks
@bnoordhuis

bnoordhuis commented Jun 22, 2018

Copy link
Copy Markdown
Member

@Trott nodejs/http-parser@89279ab

@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 22, 2018
@Trott

Trott commented Jun 22, 2018

Copy link
Copy Markdown
Member Author

👍 here for fast-tracking.

@richardlau

richardlau commented Jun 22, 2018

Copy link
Copy Markdown
Member

Thanks for updating. Perhaps in another PR we can consider how to keep things in step, either as a test or part of the build process.

@ChALkeR

ChALkeR commented Jun 24, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@Trott is there any reason why we shouldn't be just running license-builder.sh on CI and comparing the output with LICENSE file to catch license changes in the commits that introduce those?

Will it make backporting harder?

@Trott

Trott commented Jun 25, 2018

Copy link
Copy Markdown
Member Author

@Trott is there any reason why we shouldn't be just running license-builder.sh on CI and comparing the output with LICENSE file to catch license changes in the commits that introduce those?

Seems like a good idea to me. Or write a test that does that so it can be caught during make test....

Will it make backporting harder?

I don't see how, but there could be something I'm missing.

Trott added a commit to Trott/io.js that referenced this pull request Jun 25, 2018
@Trott
doc: update LICENSE file
1e7ff81 
Running `license-builder.sh` seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.

PR-URL: nodejs#21472
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@Trott

Trott commented Jun 25, 2018

Copy link
Copy Markdown
Member Author

Landed in 1e7ff81

@Trott Trott closed this Jun 25, 2018
@ChALkeR

ChALkeR commented Jun 25, 2018

Copy link
Copy Markdown
Member

@Trott

Or write a test that does that so it can be caught during make test.

That's what I meant :-).

targos pushed a commit that referenced this pull request Jun 25, 2018
@Trott @targos
doc: update LICENSE file
de195d5 
Running `license-builder.sh` seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.

PR-URL: #21472
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@Trott @MylesBorins
doc: update LICENSE file
12f7642 
Running `license-builder.sh` seems to indicate that there have been some
license changes that have not been propagated to our LICENSE file yet.
Here they are.

PR-URL: #21472
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
@Trott
Trott deleted the license branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott @nodejs-github-bot @bnoordhuis @richardlau @ChALkeR @jasnell @lpinca @cjihrig