Skip to content

doc: add boneskull as collaborator - #22917

Closed
boneskull wants to merge 1 commit into
nodejs:masterfrom
boneskull:onboarding
Closed

doc: add boneskull as collaborator#22917
boneskull wants to merge 1 commit into
nodejs:masterfrom
boneskull:onboarding

Conversation

@boneskull

@boneskull boneskull commented Sep 17, 2018 •
edited by tniessen
Loading

Copy link
Copy Markdown
Member

woo!

Checklist

@boneskull boneskull added doc Issues and PRs related to Node.js documentation. notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Sep 17, 2018
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2018

Copy link
Copy Markdown
Collaborator

@boneskull build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/916/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Sep 17, 2018
Trott
Trott approved these changes Sep 17, 2018
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 to fast-tracking.

@boneskull

boneskull commented Sep 17, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17264/

@tniessen

tniessen commented Sep 17, 2018

Copy link
Copy Markdown
Member

I approve fast-tracking.

devsnek
devsnek approved these changes Sep 17, 2018
View reviewed changes

@devsnek devsnek left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome aboard! :shipit:

@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 17, 2018
@boneskull

boneskull commented Sep 17, 2018

Copy link
Copy Markdown
Member Author

Landed in 8df13ec

@boneskull boneskull closed this Sep 17, 2018
@boneskull
boneskull deleted the onboarding branch September 17, 2018 21:46
boneskull added a commit that referenced this pull request Sep 17, 2018
@boneskull
doc: add boneskull as collaborator
8df13ec 
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 18, 2018
@boneskull @targos
doc: add boneskull as collaborator
da2c303 
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@boneskull @targos
doc: add boneskull as collaborator
97f6ff3 
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request Sep 20, 2018
@boneskull @targos
doc: add boneskull as collaborator
6e9f1d6 
PR-URL: #22917
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@tniessen tniessen tniessen approved these changes
+2 more reviewers
@devsnek devsnek devsnek approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@boneskull @nodejs-github-bot @tniessen @Trott @devsnek @vsemozhetbyt