Skip to content

src: use RAII cleanup in node_i18n.cc - #23021

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:raii-node-i18n
Closed

src: use RAII cleanup in node_i18n.cc#23021
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:raii-node-i18n

Conversation

@addaleax

@addaleax addaleax commented Sep 22, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2018

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/976/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to Node.js internationalization support. labels Sep 22, 2018
@addaleax addaleax added the lib / src Issues and PRs involving general changes in the lib/ or src/ directories. label Sep 22, 2018
@addaleax

addaleax commented Sep 23, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17389/

@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 23, 2018
@danbev

danbev commented Sep 25, 2018

Copy link
Copy Markdown
Contributor

Re-run of failing node-test-commit-linux.

@danbev

danbev commented Sep 25, 2018

Copy link
Copy Markdown
Contributor

Landed in f004936.

@danbev danbev closed this Sep 25, 2018
danbev pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @danbev
src: use RAII cleanup in node_i18n.cc
f004936 
PR-URL: #23021
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @targos
src: use RAII cleanup in node_i18n.cc
2f659a3 
PR-URL: #23021
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+2 more reviewers
@thefourtheye thefourtheye thefourtheye approved these changes
@devsnek devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to Node.js internationalization support. lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@addaleax @nodejs-github-bot @danbev @jasnell @thefourtheye @cjihrig @devsnek @gireeshpunathil @BridgeAR