Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
nodejs
/
node
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
36.7k
Star
120k
Code
Issues
635
Pull requests
571
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
dns: deprecate passing falsy hostname to dns.lookup
- #23173
#23173
Closed
oyyd
wants to merge 7 commits into
nodejs:master
nodejs/node:master
from
oyyd:remove-dns-falsy-error
oyyd/node:remove-dns-falsy-error
Copy head branch name to clipboard
Conversation
Commits
7
(7)
Checks
Files changed
Closed
dns: deprecate passing falsy hostname to dns.lookup
#23173
oyyd
wants to merge 7 commits into
nodejs:master
nodejs/node:master
from
oyyd:remove-dns-falsy-error
oyyd/node:remove-dns-falsy-error
Copy head branch name to clipboard
Commits
Commits on Sep 30, 2018
dns: deprecate passing falsy hostname to dns.lookup
Show description for 0ae969f
oyyd
committed
0ae969f
View commit details
Copy full SHA for 0ae969f
Browse repository at this point
dns: add deprecation code and fix tests
oyyd
committed
197af1c
View commit details
Copy full SHA for 197af1c
Browse repository at this point
dns: replace the deprecation number with a temporal placeholder
oyyd
committed
8b0fcee
View commit details
Copy full SHA for 8b0fcee
Browse repository at this point
dns: only emit warning once
oyyd
committed
69a614f
View commit details
Copy full SHA for 69a614f
Browse repository at this point
Commits on Oct 1, 2018
dns: fix doc typo
oyyd
committed
b73cc6d
View commit details
Copy full SHA for b73cc6d
Browse repository at this point
dns: fix doc typo
oyyd
committed
e96c0a6
View commit details
Copy full SHA for e96c0a6
Browse repository at this point
Commits on Oct 2, 2018
dns: fix doc typo
oyyd
committed
a712c0a
View commit details
Copy full SHA for a712c0a
Browse repository at this point
You can’t perform that action at this time.