Skip to content

test: update function keywords to fat arrows - #23493

Closed
RobertMonks wants to merge 1 commit into
nodejs:masterfrom
RobertMonks:master
Closed

test: update function keywords to fat arrows#23493
RobertMonks wants to merge 1 commit into
nodejs:masterfrom
RobertMonks:master

Conversation

@RobertMonks

@RobertMonks RobertMonks commented Oct 12, 2018

Copy link
Copy Markdown
Contributor

Updated all the function keywords to fat arrow implementations in test/parallel/test-event-emitter-no-error-provided-to-error-event.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@RobertMonks
test: update function keywords to fat arrows
31253ac 
Updated all the function keywords to fat arrow implementations in test/parallel/test-event-emitter-no-error-provided-to-error-event.js
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@RobertMonks @BridgeAR
test: update function keywords to fat arrows
d63c9bc 
Updated all the function keywords to fat arrow implementations in
test/parallel/test-event-emitter-no-error-provided-to-error-event.js

PR-URL: nodejs#23493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@RobertMonks @BridgeAR
test: update function keywords to fat arrows
98f170f 
Updated all the function keywords to fat arrow implementations in
test/parallel/test-event-emitter-no-error-provided-to-error-event.js

PR-URL: nodejs#23493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

BridgeAR commented Oct 15, 2018

Copy link
Copy Markdown
Member

Landed in 98f170f 🎉

@RobertMonks congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@RobertMonks @jasnell
test: update function keywords to fat arrows
5bc49f9 
Updated all the function keywords to fat arrow implementations in
test/parallel/test-event-emitter-no-error-provided-to-error-event.js

PR-URL: #23493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@RobertMonks @addaleax
test: update function keywords to fat arrows
78daac7 
Updated all the function keywords to fat arrow implementations in
test/parallel/test-event-emitter-no-error-provided-to-error-event.js

PR-URL: #23493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@RobertMonks @MylesBorins
test: update function keywords to fat arrows
fd5290e 
Updated all the function keywords to fat arrow implementations in
test/parallel/test-event-emitter-no-error-provided-to-error-event.js

PR-URL: #23493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@RobertMonks @rvagg
test: update function keywords to fat arrows
c46ddbb 
Updated all the function keywords to fat arrow implementations in
test/parallel/test-event-emitter-no-error-provided-to-error-event.js

PR-URL: #23493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@RobertMonks @MylesBorins
test: update function keywords to fat arrows
894fe38 
Updated all the function keywords to fat arrow implementations in
test/parallel/test-event-emitter-no-error-provided-to-error-event.js

PR-URL: #23493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@RobertMonks @BridgeAR @jasnell @cjihrig @gireeshpunathil @trivikr @targos @nodejs-github-bot