Skip to content

test: assert.strictEqual parameters ordered correctly - #23538

Closed
jdenbroeder wants to merge 1 commit into
nodejs:masterfrom
jdenbroeder:first-test-updates
Closed

test: assert.strictEqual parameters ordered correctly#23538
jdenbroeder wants to merge 1 commit into
nodejs:masterfrom
jdenbroeder:first-test-updates

Conversation

@jdenbroeder

@jdenbroeder jdenbroeder commented Oct 12, 2018

Copy link
Copy Markdown
Contributor

The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@jdenbroeder
test: assert.strictEqual parameters ordered correctly
7dbc40c 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@jdenbroeder @BridgeAR
test: assert.strictEqual parameters ordered correctly
f42aa0a 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

PR-URL: nodejs#23538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@jdenbroeder @BridgeAR
test: assert.strictEqual parameters ordered correctly
0b0aeda 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

PR-URL: nodejs#23538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

BridgeAR commented Oct 15, 2018

Copy link
Copy Markdown
Member

Landed in 0b0aeda 🎉

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jdenbroeder @jasnell
test: assert.strictEqual parameters ordered correctly
bd3b52f 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

PR-URL: #23538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@jdenbroeder @addaleax
test: assert.strictEqual parameters ordered correctly
d4ae8d5 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

PR-URL: #23538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@jdenbroeder @MylesBorins
test: assert.strictEqual parameters ordered correctly
a410488 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

PR-URL: #23538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jdenbroeder @rvagg
test: assert.strictEqual parameters ordered correctly
766d8f0 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

PR-URL: #23538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jdenbroeder @MylesBorins
test: assert.strictEqual parameters ordered correctly
9bc7d83 
The assert.strictEqual function should have the actual
value first and the expected value second to enable
easier debugging of AssertionErrors.

PR-URL: #23538
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jdenbroeder @BridgeAR @jasnell @cjihrig @gireeshpunathil @trivikr @targos @nodejs-github-bot