Skip to content

test: mark test-http2-session-timeout as flake on ARM - #23639

Closed
refack wants to merge 1 commit into
nodejs:masterfrom
refack:mark-new-flake
Closed

test: mark test-http2-session-timeout as flake on ARM#23639
refack wants to merge 1 commit into
nodejs:masterfrom
refack:mark-new-flake

Conversation

@refack

@refack refack commented Oct 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #20628

Please 👍 to fast-track

CI: https://ci.nodejs.org/job/node-test-pull-request/17810/
https://ci.nodejs.org/job/node-test-pull-request/17812/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@refack refack added test Issues and PRs related to Node.js core tests and test infrastructure. flaky-test Issues and PRs involving tests that fail intermittently in CI. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Oct 13, 2018
@refack refack self-assigned this Oct 13, 2018
@refack
refack requested a review from Trott October 13, 2018 14:22
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2018

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1227/pipeline

@refack

refack commented Oct 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/CC @nodejs/testing @nodejs/http2 @nodejs/platform-arm

@refack refack mentioned this pull request Oct 13, 2018
Closed
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 13, 2018
@addaleax

addaleax commented Oct 13, 2018

Copy link
Copy Markdown
Member

Landed in 882e022

@addaleax addaleax closed this Oct 13, 2018
addaleax pushed a commit that referenced this pull request Oct 13, 2018
@refack @addaleax
test: mark test-http2-session-timeout as flake on ARM
882e022 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
@refack refack removed their assignment Oct 13, 2018
@refack
refack deleted the mark-new-flake branch October 13, 2018 18:53
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@refack @addaleax
test: mark test-http2-session-timeout as flake on ARM
59ecf06 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@refack @jasnell
test: mark test-http2-session-timeout as flake on ARM
5e68333 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@refack @MylesBorins
test: mark test-http2-session-timeout as flake on ARM
75d4bf2 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@refack @rvagg
test: mark test-http2-session-timeout as flake on ARM
9cfa1f6 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@refack @MylesBorins
test: mark test-http2-session-timeout as flake on ARM
51aa50c 
PR-URL: #23639
Refs: #20628
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. flaky-test Issues and PRs involving tests that fail intermittently in CI. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@refack @nodejs-github-bot @addaleax @Trott