test: check for invalid importModuleDynamically type in vm.js - #24161
Closed
alyssaq wants to merge 1 commit into
Closed
test: check for invalid importModuleDynamically type in vm.js#24161alyssaq wants to merge 1 commit into
alyssaq wants to merge 1 commit into
Conversation
addaleax
approved these changes
Nov 6, 2018
2 tasks
BridgeAR
approved these changes
Nov 6, 2018
jasnell
approved these changes
Nov 10, 2018
Member
Member
There was a problem hiding this comment.
linter failed due to missing semicolon here; @alyssaq - can you please make that change?
Member
gireeshpunathil
approved these changes
Nov 13, 2018
Member
|
landed as dde9b3a , thanks! |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 13, 2018
PR-URL: #24161 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24161 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24161 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Nov 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test for checking the thrown error when the option
importModuleDynamicallyis not a function.