Skip to content

test: modified order of parameters for assertion - #24430

Closed
fiveobjects wants to merge 1 commit into
nodejs:masterfrom
fiveobjects:jsassert14
Closed

test: modified order of parameters for assertion#24430
fiveobjects wants to merge 1 commit into
nodejs:masterfrom
fiveobjects:jsassert14

Conversation

@fiveobjects

@fiveobjects fiveobjects commented Nov 17, 2018

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 17, 2018
@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes

@targos targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Commit message should start with test: modify ...

@targos

targos commented Nov 17, 2018

Copy link
Copy Markdown
Member

👍 to fast-track

@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 17, 2018
@gireeshpunathil

gireeshpunathil commented Nov 18, 2018

Copy link
Copy Markdown
Member

@fiveobjects -

  1. please see if you can make the changes that @targos suggested. It is something that we can do while landing; but appreciate if you make an attempt, as doing so strengthens the learning, to the spirit of the code & learn, thanks!

  2. if you'd like you can associate your email with your GitHub account. That way we and GitHub will credit the code contributions you make to you. See https://github.com/settings/emails and the guide at https://help.github.com/articles/setting-your-commit-email-address-on-github/

@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18747/

@Trott

Trott commented Nov 19, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18772/

thefourtheye
thefourtheye reviewed Nov 20, 2018
View reviewed changes
Comment thread test/parallel/test-promises-unhandled-rejections.js
@@ -634,8 +634,8 @@ asyncTest(
const e = new Error('error');
const domainError = new Error('domain error');
onUnhandledSucceed(done, function(reason, promise) {

@thefourtheye thefourtheye Nov 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: A common.mustCall around this would be better.

@Trott

Trott commented Nov 20, 2018

Copy link
Copy Markdown
Member

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18785/

@Trott

Trott commented Nov 20, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18788/

@Trott

Trott commented Nov 20, 2018

Copy link
Copy Markdown
Member

That test-stream-pipeline issue is being pretty stubborn but is also pretty clearly unrelated. Let's do a full CI: https://ci.nodejs.org/job/node-test-pull-request/18815/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 20, 2018
@msahacode @Trott
test: modify order of parameters for assertion
7ba83e8 
PR-URL: nodejs#24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott

Trott commented Nov 20, 2018

Copy link
Copy Markdown
Member

Landed in 7ba83e8.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 20, 2018
targos pushed a commit that referenced this pull request Nov 21, 2018
@msahacode @targos
test: modify order of parameters for assertion
7f76563 
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@msahacode @rvagg
test: modify order of parameters for assertion
ed714a2 
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@msahacode @codebytere
test: modify order of parameters for assertion
e642050 
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@msahacode @refack
test: modify order of parameters for assertion
190e250 
PR-URL: nodejs#24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@msahacode @codebytere
test: modify order of parameters for assertion
e7d41c0 
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes
+2 more reviewers
@thefourtheye thefourtheye thefourtheye approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.