Skip to content

test: fix the arguments order in assert.strictEqual - #24610

Closed
sigwyg wants to merge 1 commit into
nodejs:masterfrom
sigwyg:sigwyg-fixed-strictEqual
Closed

test: fix the arguments order in assert.strictEqual#24610
sigwyg wants to merge 1 commit into
nodejs:masterfrom
sigwyg:sigwyg-fixed-strictEqual

Conversation

@sigwyg

@sigwyg sigwyg commented Nov 24, 2018

Copy link
Copy Markdown

I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Nov 24, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil

Copy link
Copy Markdown
Member

potentially duplicate of #24592

@sigwyg

sigwyg commented Nov 24, 2018

Copy link
Copy Markdown
Author

Oops! This PR Closing...

@sigwyg sigwyg closed this Nov 24, 2018
@sigwyg
sigwyg deleted the sigwyg-fixed-strictEqual branch November 24, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants