test: fix the arguments order in assert.strictEqual - #24626
Closed
rt33 wants to merge 1 commit into
Closed
Conversation
gireeshpunathil
approved these changes
Nov 24, 2018
Leko
approved these changes
Nov 24, 2018
cjihrig
approved these changes
Nov 24, 2018
lpinca
approved these changes
Nov 24, 2018
Member
Member
|
fast-track? pls 👍 |
watilde
approved these changes
Nov 26, 2018
Leko
approved these changes
Nov 26, 2018
fhinkel
approved these changes
Nov 27, 2018
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19018/ |
Member
|
Landed in c481799 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 29, 2018
PR-URL: nodejs#24626 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #24626 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24626 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24626 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24626 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
strictEqualarguments orderChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes