Skip to content

test: mark test-worker-memory flaky on Windows CI - #25042

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mark-flaky-memory
Closed

test: mark test-worker-memory flaky on Windows CI#25042
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mark-flaky-memory

Conversation

@Trott

@Trott Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

Collaborators, please 👍 to fast-track.

Refs: #23277

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added windows Issues and PRs related to the Windows platform. test Issues and PRs related to Node.js core tests and test infrastructure. flaky-test Issues and PRs involving tests that fail intermittently in CI. fast-track PRs proposed for a shorter-than-standard waiting period before landing. worker Issues and PRs related to the worker_threads module and Worker API. labels Dec 14, 2018
@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1947/pipeline

@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19518/

@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19526/

@Trott

Trott commented Dec 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19534/ ✔️

@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member Author

Landed in 87006be

@Trott Trott closed this Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@Trott
test: mark test-worker-memory flaky on Windows CI
87006be 
Refs: nodejs#23277

PR-URL: nodejs#25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@Trott @BethGriggs
test: mark test-worker-memory flaky on Windows CI
2825894 
Refs: #23277

PR-URL: #25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
sagitsofan pushed a commit to sagitsofan/node that referenced this pull request Dec 24, 2018
@Trott @sagitsofan
test: mark test-worker-memory flaky on Windows CI
52a54c4 
Refs: nodejs#23277

PR-URL: nodejs#25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: mark test-worker-memory flaky on Windows CI
731db7b 
Refs: nodejs#23277

PR-URL: nodejs#25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott @BethGriggs
test: mark test-worker-memory flaky on Windows CI
55680e3 
Refs: #23277

PR-URL: #25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott @BethGriggs
test: mark test-worker-memory flaky on Windows CI
3a2a08d 
Refs: #23277

PR-URL: #25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: mark test-worker-memory flaky on Windows CI
241986d 
Refs: #23277

PR-URL: #25042
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott
Trott deleted the mark-flaky-memory branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. flaky-test Issues and PRs involving tests that fail intermittently in CI. test Issues and PRs related to Node.js core tests and test infrastructure. windows Issues and PRs related to the Windows platform. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott @nodejs-github-bot @cjihrig @gireeshpunathil @BethGriggs