Skip to content

tools: replace NULL for nullptr - #25179

Closed
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:cpp-nullptr
Closed

tools: replace NULL for nullptr#25179
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:cpp-nullptr

Conversation

@juanarbol

@juanarbol juanarbol commented Dec 22, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to Node.js internationalization support. tools Issues and PRs related to the tools directory. labels Dec 22, 2018
addaleax
addaleax approved these changes Dec 22, 2018
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @srl295 I assume it’s okay to modify this file?

@addaleax

ghost commented Dec 27, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19838/

@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 27, 2018
@addaleax

ghost commented Dec 31, 2018 •
edited by Trott
Loading

Copy link
Copy Markdown
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19886/ ✅

@Trott

ghost commented Dec 31, 2018

Copy link
Copy Markdown
Member

Landed in a2f81df

@Trott Trott closed this Dec 31, 2018
@juanarbol
juanarbol deleted the cpp-nullptr branch January 2, 2019 10:13
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. i18n-api Issues and PRs related to Node.js internationalization support. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@juanarbol @addaleax @Trott @jasnell @cjihrig @tniessen @nodejs-github-bot