Skip to content

test: add test for worker.terminate() + timeout fns - #25735

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:setimmediate-test
Closed

test: add test for worker.terminate() + timeout fns#25735
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:setimmediate-test

Conversation

@addaleax

@addaleax addaleax commented Jan 27, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2404/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jan 27, 2019
@addaleax addaleax added the worker Issues and PRs related to the worker_threads module and Worker API. label Jan 27, 2019
@addaleax

addaleax commented Jan 28, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20392/

@addaleax

addaleax commented Jan 29, 2019

Copy link
Copy Markdown
Member Author

Landed in ef307bf

@addaleax addaleax closed this Jan 29, 2019
@addaleax
addaleax deleted the setimmediate-test branch January 29, 2019 18:20
addaleax added a commit that referenced this pull request Jan 29, 2019
@addaleax
test: add test for worker.terminate() + timeout fns
ef307bf 
PR-URL: #25735
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 29, 2019
@addaleax @targos
test: add test for worker.terminate() + timeout fns
15f6b8e 
PR-URL: #25735
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax @nodejs-github-bot @jasnell @cjihrig @gireeshpunathil